Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2706)

Unified Diff: device/bluetooth/test/bluetooth_test.h

Issue 2783733002: Bluetooth: Add service data unit tests for chromeos (Closed)
Patch Set: trybot Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/test/bluetooth_test.h
diff --git a/device/bluetooth/test/bluetooth_test.h b/device/bluetooth/test/bluetooth_test.h
index 96fca52895d0c1a00fc81921cedaa91715a505ad..b6610ea903143e8b198ed24067cdd7c6446f6c0c 100644
--- a/device/bluetooth/test/bluetooth_test.h
+++ b/device/bluetooth/test/bluetooth_test.h
@@ -130,6 +130,14 @@ class BluetoothTestBase : public testing::Test {
virtual bool DenyPermission();
// Create a fake Low Energy device and discover it.
+ // |device_ordinal| with the same device address stands for the same fake
ortuno 2017/04/03 02:47:25 Thanks for this!
+ // device with different properties.
+ // For example:
+ // SimulateLowEnergyDevice(2); << First call will create a device with address
+ // kTestDeviceAddress1
+ // SimulateLowEnergyDevice(3); << Second call will update changes to the
+ // device of address kTestDeviceAddress1.
+ //
// |device_ordinal| selects between multiple fake device data sets to produce:
// 1: Name: kTestDeviceName
// Address: kTestDeviceAddress1
@@ -141,8 +149,8 @@ class BluetoothTestBase : public testing::Test {
// Address: kTestDeviceAddress1
// RSSI: kTestRSSI2
// Advertised UUIDs: {kTestUUIDImmediateAlert, kTestUUIDLinkLoss}
- // Service Data: {kTestUUIDHeartRate: [2],
- // kTestUUIDImmediateAlert: [0]}
+ // Service Data: {kTestUUIDHeartRate: [],
+ // kTestUUIDImmediateAlert: [0, 2]}
// Tx Power: kTestTxPower2
// 3: Name: kTestDeviceNameEmpty
// Address: kTestDeviceAddress1

Powered by Google App Engine
This is Rietveld 408576698