Bluetooth: Add service data unit tests for chromeos

device/bluetooth/bluetooth_device_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 149 matching lines @@
     return;
   }
   InitWithFakeAdapter();
   StartLowEnergyDiscoverySession();
   BluetoothDevice* device = SimulateLowEnergyDevice(3);
   ASSERT_TRUE(device);
   UUIDSet uuids = device->GetUUIDs();
   EXPECT_EQ(0u, uuids.size());
 }
 
-#if defined(OS_MACOSX)
+#if defined(OS_MACOSX) || defined(OS_CHROMEOS)

[ortuno, 2017/03/30 02:58:14]

Would you mind enabling this on Linux as well?

Also we can remove:
https://cs.chromium.org/chromium/src/device/bluetooth/bluez/bluetooth_bluez_u...

[Miao, 2017/03/30 21:20:07]

Agree on this, we don't have any Chromium specific changes on parsing and
storing the service data. The test here is good enough to cover the old one.

[xiaoyinh(OOO Sep 11-29), 2017/03/31 16:26:53]

Done.

 // TODO(ortuno): Enable on Android once it supports Service Data.
 // http://crbug.com/639408
 TEST_F(BluetoothTest, GetServiceDataUUIDs_GetServiceDataForUUID) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
   }
   InitWithFakeAdapter();
+
+#if !defined(OS_CHROMEOS)
+  // StartLowEnergyDiscoverySession is not yet implemented on ChromeOS|bluez.

[ortuno, 2017/03/30 02:58:14]

nit: TODO(crbug.com/706043): Remove #if once StartLowEnergyDiscoverySession is
implemented for bluez.

[xiaoyinh(OOO Sep 11-29), 2017/03/31 16:26:52]

Done.

+  // http://crbug.com/706043
   StartLowEnergyDiscoverySession();
+#endif
 
   // Receive Advertisement with service data.
   BluetoothDevice* device = SimulateLowEnergyDevice(1);
 
   EXPECT_EQ(ServiceDataMap({{BluetoothUUID(kTestUUIDHeartRate), {1}}}),
             device->GetServiceData());
   EXPECT_EQ(UUIDSet({BluetoothUUID(kTestUUIDHeartRate)}),
             device->GetServiceDataUUIDs());
   EXPECT_EQ(std::vector<uint8_t>({1}),
             *device->GetServiceDataForUUID(BluetoothUUID(kTestUUIDHeartRate)));
 
   // Receive Advertisement with no service data.
   SimulateLowEnergyDevice(3);

[Miao, 2017/03/30 21:20:07]

The expected outcomes of service data and UUIDs are different between CrOS/Linux
and Mac if the new advertisement event does not contain any service data. In
this case, BlueZ does not clean up the previously-found service data. Therefore,
separate checks are needed for CrOS/Linux.

[xiaoyinh(OOO Sep 11-29), 2017/03/31 16:26:53]

Done.

 
   EXPECT_TRUE(device->GetServiceData().empty());
   EXPECT_TRUE(device->GetServiceDataUUIDs().empty());
   EXPECT_EQ(nullptr,
             device->GetServiceDataForUUID(BluetoothUUID(kTestUUIDHeartRate)));
 
   // Receive Advertisement with new service data.
   SimulateLowEnergyDevice(2);
 
-  EXPECT_EQ(ServiceDataMap({{BluetoothUUID(kTestUUIDHeartRate), {2}},
-                            {BluetoothUUID(kTestUUIDImmediateAlert), {0}}}),
+  EXPECT_EQ(ServiceDataMap({{BluetoothUUID(kTestUUIDHeartRate), {}},
+                            {BluetoothUUID(kTestUUIDImmediateAlert), {0, 2}}}),
             device->GetServiceData());
   EXPECT_EQ(UUIDSet({BluetoothUUID(kTestUUIDHeartRate),
                      BluetoothUUID(kTestUUIDImmediateAlert)}),
             device->GetServiceDataUUIDs());
-  EXPECT_EQ(std::vector<uint8_t>({2}),
+  EXPECT_EQ(std::vector<uint8_t>({}),
             *device->GetServiceDataForUUID(BluetoothUUID(kTestUUIDHeartRate)));
   EXPECT_EQ(
-      std::vector<uint8_t>({0}),
+      std::vector<uint8_t>({0, 2}),
       *device->GetServiceDataForUUID(BluetoothUUID(kTestUUIDImmediateAlert)));
 
+#if !defined(OS_CHROMEOS)

[ortuno, 2017/03/30 02:58:14]

TODO(crbug.com/706043): Remove #if once StartLowEnergyDiscoverySession is
implemented for bluez.

[xiaoyinh(OOO Sep 11-29), 2017/03/31 16:26:52]

Done.

   // Stop discovery.
   discovery_sessions_[0]->Stop(GetCallback(Call::EXPECTED),
                                GetErrorCallback(Call::NOT_EXPECTED));
   ASSERT_FALSE(adapter_->IsDiscovering());
   ASSERT_FALSE(discovery_sessions_[0]->IsActive());
 
   EXPECT_TRUE(device->GetServiceData().empty());
   EXPECT_TRUE(device->GetServiceDataUUIDs().empty());
   EXPECT_EQ(nullptr,
             device->GetServiceDataForUUID(BluetoothUUID(kTestUUIDHeartRate)));
   EXPECT_EQ(nullptr, device->GetServiceDataForUUID(
                          BluetoothUUID(kTestUUIDImmediateAlert)));
+#endif
 }
 #endif  // defined(OS_MACOSX)
 
 #if defined(OS_ANDROID) || defined(OS_MACOSX)
 // Tests that the Advertisement Data fields are correctly updated during
 // discovery.
 TEST_F(BluetoothTest, AdvertisementData_Discovery) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
@@ skipping 1377 matching lines @@
                   .empty());
   EXPECT_TRUE(device_
                   ->GetCharacteristicsByUUID(
                       service_instance_id2,
                       BluetoothUUID(characteristic_uuid_not_exist_in_setup))
                   .empty());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_MACOSX)
 
 }  // namespace device