content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 2783723002: Keep track in the browser of which frames have onunload and onbeforeunload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2783723002: Keep track in the browser of which frames have onunload and onbeforeunload handlers. (Closed)

Patch Set: fix content_browsertests with plznavigate and also remove now unnecessary unloadcontroller change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index bf807ff9339efa73103a3370a6e8e8c4abd39114..924873625295deb322cde30e702c5bd3ffef35a5 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -1020,6 +1020,29 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,

}

namespace {

+void NavigateToDataURLAndExpectBeforeUnload(Shell* shell,

+ const std::string& html,

+ bool expect_onbeforeunload) {

+ NavigateToURL(shell, GURL("data:text/html," + html));

+ RenderFrameHostImpl* rfh =

+ static_cast<RenderFrameHostImpl*>(shell->web_contents()->GetMainFrame());

+ EXPECT_EQ(expect_onbeforeunload, rfh->ShouldDispatchBeforeUnload());

+} // namespace

+IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, NoOnBeforeUnload) {

+ const std::string NO_BEFORE_UNLOAD_HTML = "<html><body>foo</body></html>";

+ NavigateToDataURLAndExpectBeforeUnload(shell(), NO_BEFORE_UNLOAD_HTML, false);

+IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, OnBeforeUnload) {

+ const std::string BEFORE_UNLOAD_HTML =

+ "<html><body><script>window.onbeforeunload=function(e) {}</script>"

+ "</body></html>";

+ NavigateToDataURLAndExpectBeforeUnload(shell(), BEFORE_UNLOAD_HTML, true);

+namespace {

class TestJavaScriptDialogManager : public JavaScriptDialogManager,

public WebContentsDelegate {