content/browser/devtools/protocol/devtools_protocol_browsertest.cc - Issue 2783723002: Keep track in the browser of which frames have onunload and onbeforeunload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2783723002: Keep track in the browser of which frames have onunload and onbeforeunload handlers. (Closed)

Patch Set: fix content_browsertests with plznavigate and also remove now unnecessary unloadcontroller change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

index 20d5c188d85d14ff86a5b8a34997ee952e531e12..d771e0e1ec8e04c94b8970a6d580ec6fdc593205 100644

--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

@@ -283,7 +283,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,

std::vector<ExpectedNavigation> expected_navigations) {

while (!expected_navigations.empty()) {

std::unique_ptr<base::DictionaryValue> params =

- WaitForNotification("Page.navigationRequested");

+ WaitForNotification("Page.navigationRequested", true);

std::string url;

ASSERT_TRUE(params->GetString("url", &url));