Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2783703005: Fix inconsistent removal of imports during tree-shaking. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inconsistent removal of imports during tree-shaking. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/8e99919c92141a1663cec9cec1f040f589d76e83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 8 months ago (2017-03-30 01:11:59 UTC) #2
Florian Schneider
Lgtm. Good catch!
3 years, 8 months ago (2017-03-30 02:14:54 UTC) #3
rmacnak
3 years, 8 months ago (2017-03-30 19:33:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e99919c92141a1663cec9cec1f040f589d76e83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698