Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/spdy/bidirectional_stream_spdy_impl.h

Issue 2783683002: Log source_dependency in HTTP2_SESSION_SEND_HEADERS. (Closed)
Patch Set: Fix use-after-free. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/bidirectional_stream_spdy_impl.h
diff --git a/net/spdy/bidirectional_stream_spdy_impl.h b/net/spdy/bidirectional_stream_spdy_impl.h
index b5398b3527406946d26d018fc6df01460cb84f24..9e97b9142eea4fb3a69c3e6fd06e5f3feccfa028 100644
--- a/net/spdy/bidirectional_stream_spdy_impl.h
+++ b/net/spdy/bidirectional_stream_spdy_impl.h
@@ -18,6 +18,7 @@
#include "net/http/bidirectional_stream_impl.h"
#include "net/http/bidirectional_stream_request_info.h"
#include "net/http/http_request_info.h"
+#include "net/log/net_log_source.h"
#include "net/spdy/spdy_read_queue.h"
#include "net/spdy/spdy_session.h"
#include "net/spdy/spdy_stream.h"
@@ -36,8 +37,8 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
: public BidirectionalStreamImpl,
public SpdyStream::Delegate {
public:
- explicit BidirectionalStreamSpdyImpl(
- const base::WeakPtr<SpdySession>& spdy_session);
+ BidirectionalStreamSpdyImpl(const base::WeakPtr<SpdySession>& spdy_session,
+ NetLogSource source_dependency);
~BidirectionalStreamSpdyImpl() override;
@@ -67,6 +68,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
void OnDataSent() override;
void OnTrailers(const SpdyHeaderBlock& trailers) override;
void OnClose(int status) override;
+ NetLogSource source_dependency() const override;
private:
int SendRequestHeadersHelper();
@@ -87,6 +89,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
std::unique_ptr<base::Timer> timer_;
SpdyStreamRequest stream_request_;
base::WeakPtr<SpdyStream> stream_;
+ const NetLogSource source_dependency_;
NextProto negotiated_protocol_;
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698