Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278363002: Add a command line flag to enable WebGL overlay support. (Closed)

Created:
6 years, 7 months ago by alexst (slow to review)
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Add a command line flag to enable WebGL overlay support. BUG=372449 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272244

Patch Set 1 #

Total comments: 1

Patch Set 2 : added chrome_restart_request.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
alexst (slow to review)
blink change going into cq today, this is the command line flag to enable it.
6 years, 7 months ago (2014-05-20 13:27:57 UTC) #1
piman
https://codereview.chromium.org/278363002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/278363002/diff/1/content/public/common/content_switches.cc#newcode578 content/public/common/content_switches.cc:578: const char kEnableWebGLImageChromium[] = "enable-webgl-image-chromium"; Can you also add ...
6 years, 7 months ago (2014-05-20 17:07:20 UTC) #2
alexst (slow to review)
ptal
6 years, 7 months ago (2014-05-20 17:52:37 UTC) #3
piman
lgtm
6 years, 7 months ago (2014-05-20 20:31:24 UTC) #4
alexst (slow to review)
The CQ bit was checked by alexst@chromium.org
6 years, 7 months ago (2014-05-22 00:29:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/278363002/20001
6 years, 7 months ago (2014-05-22 00:30:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:21:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:24:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9715)
6 years, 7 months ago (2014-05-22 10:24:16 UTC) #9
alexst (slow to review)
The CQ bit was checked by alexst@chromium.org
6 years, 7 months ago (2014-05-22 13:08:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/278363002/20001
6 years, 7 months ago (2014-05-22 13:09:40 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:12:42 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 13:14:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9715)
6 years, 7 months ago (2014-05-22 13:14:36 UTC) #14
alexst (slow to review)
The CQ bit was checked by alexst@chromium.org
6 years, 7 months ago (2014-05-22 13:59:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/278363002/20001
6 years, 7 months ago (2014-05-22 14:00:18 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 14:03:43 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:05:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9715)
6 years, 7 months ago (2014-05-22 14:05:42 UTC) #19
alexst (slow to review)
The CQ bit was checked by alexst@chromium.org
6 years, 7 months ago (2014-05-22 17:25:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/278363002/20001
6 years, 7 months ago (2014-05-22 17:27:48 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 18:27:22 UTC) #22
Message was sent while issue was closed. 
Change committed as 272244

Powered by Google App Engine
This is Rietveld 408576698