Fetch API: Don't exclude the URL fragment in Request#url

third_party/WebKit/Source/modules/fetch/Request.cpp

Index: third_party/WebKit/Source/modules/fetch/Request.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Request.cpp b/third_party/WebKit/Source/modules/fetch/Request.cpp
index 666857c4d2cfa63055052f5c2b60276572164c31..39ecc2a72135122f8ef38a849f028c494434b789 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Request.cpp
@@ -493,13 +493,7 @@ String Request::method() const {
 }
 
 KURL Request::url() const {
-  // The url attribute's getter must return request's url, serialized with the
-  // exclude fragment flag set.
-  if (!m_request->url().hasFragmentIdentifier())
-    return m_request->url();
-  KURL url(m_request->url());
-  url.removeFragmentIdentifier();
-  return url;
+  return m_request->url();
 }
 
 String Request::context() const {
@@ -696,8 +690,12 @@ void Request::populateWebServiceWorkerRequest(
     WebServiceWorkerRequest& webRequest) const {
   webRequest.setMethod(method());
   webRequest.setRequestContext(m_request->context());
-  // This strips off the fragment part.
-  webRequest.setURL(url());
+
+  // Strips off the fragment part of URL.

[falken, 2017/03/31 06:40:49]

nit: "Strips" -> "Strip" is more consistent with the codebase's comments. I'd
also add a comment about why we're doing this. "So far, all users of
WebServiceWorkerRequest expect the fragment to be excluded."

[yiyix, 2017/03/31 07:24:02]

Done.

+  KURL url(m_request->url());
+  if (m_request->url().hasFragmentIdentifier())
+    url.removeFragmentIdentifier();
+  webRequest.setURL(url);
 
   const FetchHeaderList* headerList = m_headers->headerList();
   for (size_t i = 0, size = headerList->size(); i < size; ++i) {