third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 2783593002: Redraw media volume slider when it is moving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2783593002: Redraw media volume slider when it is moving (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index 6fcf2642e672bbb9fa145f243b43bcf7045fa993..bd8c71f13922c3a8dcf82ecc1485e1c19f12eb6b 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -806,6 +806,8 @@ void MediaControls::onVolumeChange() {

m_volumeSlider->setIsWanted(mediaElement().hasAudio() &&

!preferHiddenVolumeControls(document()));

m_muteButton->setIsWanted(mediaElement().hasAudio());

+ invalidate(m_muteButton);

CJ 2017/03/28 14:58:38 Is this necessary?

+ invalidate(m_volumeSlider);

}

void MediaControls::onFocusIn() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »