Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2783543004: Move registration of LocalFrame mojo interfaces to ModulesInitializer. (Closed)
Patch Set: Address code review feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 123b53e93dd58fb59dac7e479c8f5afbbc059afe..c5570e4e1674f1d4e4b3344599d23620773b5247 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -158,8 +158,6 @@
#include "core/style/StyleInheritedData.h"
#include "core/timing/DOMWindowPerformance.h"
#include "core/timing/Performance.h"
-#include "modules/app_banner/AppBannerController.h"
-#include "modules/installation/InstallationServiceImpl.h"
#include "platform/ScriptForbiddenScope.h"
#include "platform/UserGestureIndicator.h"
#include "platform/WebFrameScheduler.h"
@@ -182,8 +180,6 @@
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/SchemeRegistry.h"
#include "platform/weborigin/SecurityPolicy.h"
-#include "public/platform/InterfaceProvider.h"
-#include "public/platform/InterfaceRegistry.h"
#include "public/platform/WebDoubleSize.h"
#include "public/platform/WebFloatPoint.h"
#include "public/platform/WebFloatRect.h"
@@ -1615,14 +1611,6 @@ void WebLocalFrameImpl::initializeCoreFrame(Page& page,
frame()->document()->getSecurityOrigin()->grantUniversalAccess();
}
- // TODO(dominickn): This interface should be document-scoped rather than
- // frame-scoped, as the resulting banner event is dispatched to
- // frame()->document().
- frame()->interfaceRegistry()->addInterface(WTF::bind(
- &AppBannerController::bindMojoRequest, wrapWeakPersistent(frame())));
-
- frame()->interfaceRegistry()->addInterface(WTF::bind(
- &InstallationServiceImpl::create, wrapWeakPersistent(frame())));
if (!owner) {
// This trace event is needed to detect the main frame of the
// renderer in telemetry metrics. See crbug.com/692112#c11.

Powered by Google App Engine
This is Rietveld 408576698