Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2783543004: Move registration of LocalFrame mojo interfaces to ModulesInitializer. (Closed)
Patch Set: Address code review feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 5f274e82dce30ae1a338a1b2157b0bb956726ca4..fe7ccc9d17f6d83c7ee97c01943e4c2f4efeac22 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -227,6 +227,13 @@ class CORE_EXPORT LocalFrame final : public Frame,
PerformanceMonitor* performanceMonitor() { return m_performanceMonitor; }
+ using FrameInitCallback = void (*)(LocalFrame*);
+ // Allows for the registration of a callback that is invoked whenever a new
+ // LocalFrame is initilized. Callbacks are executed in the order that they
haraken 2017/03/29 08:10:24 initialized
slangley 2017/03/29 23:09:38 Done
+ // were added using registerInitializationCallback, and there are no checks
+ // for adding a callback multiple times.
+ static void registerInitializationCallback(FrameInitCallback);
+
private:
friend class FrameNavigationDisabler;
@@ -277,10 +284,6 @@ class CORE_EXPORT LocalFrame final : public Frame,
InterfaceRegistry* const m_interfaceRegistry;
};
-inline void LocalFrame::init() {
- m_loader.init();
-}
-
inline FrameLoader& LocalFrame::loader() const {
return m_loader;
}

Powered by Google App Engine
This is Rietveld 408576698