content/browser/web_contents/web_contents_impl.cc - Issue 278353003: Make RendererMediaPlayerManager a RenderFrameObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 278353003: Make RendererMediaPlayerManager a RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 47871dc6e5e25be55f31073bbf4d3fd1f6cc9c9e..1f3d12c3d6c5839311b1f8554db5c9a59dc80794 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3299,11 +3299,6 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,

NotifyDisconnected();

SetIsCrashed(status, error_code);

-#if defined(OS_ANDROID)

- if (GetRenderViewHostImpl()->media_player_manager())

- GetRenderViewHostImpl()->media_player_manager()->DestroyAllMediaPlayers();

xhwang 2014/05/12 17:01:58 This should be taken care of by MediaWebContentsOb

-#endif

FOR_EACH_OBSERVER(WebContentsObserver,

observers_,

RenderProcessGone(GetCrashedStatus()));