Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: content/browser/android/surface_texture_peer_browser_impl.cc

Issue 278353003: Make RendererMediaPlayerManager a RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/surface_texture_peer_browser_impl.cc
diff --git a/content/browser/android/surface_texture_peer_browser_impl.cc b/content/browser/android/surface_texture_peer_browser_impl.cc
index 7935c9ab409b15bad3d7cf32eefd742d563947f0..66b04373c703e5018075781ed5f205e5ef734a67 100644
--- a/content/browser/android/surface_texture_peer_browser_impl.cc
+++ b/content/browser/android/surface_texture_peer_browser_impl.cc
@@ -5,6 +5,7 @@
#include "content/browser/android/surface_texture_peer_browser_impl.h"
#include "content/browser/media/android/browser_media_player_manager.h"
+#include "content/browser/media/android/media_web_contents_observer.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
@@ -32,18 +33,44 @@ static void SetSurfacePeer(
it.Advance();
}
- if (renderer_id) {
- RenderViewHostImpl* host = RenderViewHostImpl::FromID(
- renderer_id, render_view_id);
- if (host) {
- media::MediaPlayerAndroid* player =
- host->media_player_manager()->GetPlayer(player_id);
- if (player &&
- player != host->media_player_manager()->GetFullscreenPlayer()) {
- gfx::ScopedJavaSurface surface(surface_texture.get());
- player->SetVideoSurface(surface.Pass());
- }
- }
+ if (!renderer_id) {
+ DVLOG(1) << "Cannot find renderer for " << render_process_handle;
+ return;
+ }
+
+ RenderViewHostImpl* host =
+ RenderViewHostImpl::FromID(renderer_id, render_view_id);
+
+ if (!host) {
+ DVLOG(1) << "Cannot find host for render_view" << render_view_id;
+ return;
+ }
+
+ // TODO(xhwang): This assumes all media elements are in the main frame which
+ // is not true. Update the SetSurfacePeer() stack to use |render_frame_id|
+ // instead of |render_view_id|.
+ RenderFrameHost* frame = host->GetMainFrame();
+ if (!frame) {
+ DVLOG(1) << "Cannot find the main frame.";
+ return;
+ }
+
+ BrowserMediaPlayerManager* player_manager =
+ host->media_web_contents_observer()->GetMediaPlayerManager(frame);
+ if (!player_manager) {
+ DVLOG(1) << "Cannot find the media player manager for frame " << frame;
+ return;
+ }
+
+ media::MediaPlayerAndroid* player = player_manager->GetPlayer(player_id);
+ if (!player) {
+ DVLOG(1) << "Cannot find the media player player_id " << player_id;
+ return;
+ }
+
+ if (player != player_manager->GetFullscreenPlayer()) {
+ gfx::ScopedJavaSurface scoped_surface(surface_texture);
+ player->SetVideoSurface(scoped_surface.Pass());
}
}

Powered by Google App Engine
This is Rietveld 408576698