chrome/android/java/res/layout/infobar_translate_tab_content.xml - Issue 2783523002: Create the customized TabLayout for the new translate UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/infobar_translate_tab_content.xml

Issue 2783523002: Create the customized TabLayout for the new translate UI (Closed)

Patch Set: Use layout XML and use Framelayout. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabContent.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabContent.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.infobar.translate.TranslateTabContent

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:id="@+id/translate_tabcontent"

	9 android:layout_width="wrap_content"

	10 android:layout_height="wrap_content">

	11 <!-- Add both the textView and progressBar to the tab, and only keep one of them visible.

	12 This way the width of the Tab will always be fixed no matter which one is visible. -->

	13 <TextView

	14 android:id="@+id/translate_infobar_tab_text"

	15 android:layout_width="wrap_content"

	16 android:layout_height="wrap_content"

	17 android:layout_gravity="center"

	18 android:visibility="visible"/>
	gone 2017/03/29 17:04:10 I prefer keeping a space between the " and the />, I prefer keeping a space between the " and the />, like you do for the ProgressBar. Same above, for the parent. Marti Wong 2017/03/29 23:38:07 Done. Show quoted text On 2017/03/29 17:04:10, dfalcantara (load balance plz) wrote: > I prefer keeping a space between the " and the />, like you do for the > ProgressBar. Same above, for the parent. Done.
	19 <ProgressBar

	20 android:id="@+id/translate_infobar_tab_progressbar"

	21 android:layout_width="@dimen/infobar_small_icon_size"

	22 android:layout_height="@dimen/infobar_small_icon_size"

	23 android:layout_gravity="center"

	24 android:indeterminate="true"

	25 android:visibility="invisible" />

	26 </org.chromium.chrome.browser.infobar.translate.TranslateTabContent>

OLD	NEW