third_party/WebKit/Source/core/css/CSSFontSelector.cpp - Issue 2783483003: Revert of Skip nullptr after copyToVector() from HeapHashSet<WeakMember>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 2783483003: Revert of Skip nullptr after copyToVector() from HeapHashSet<WeakMember> (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

index 48bc761b5477f9c65b50c18b90db82a814de017e..a5970731553f047a430e143a04a386c9331c6220 100644

--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp

@@ -73,12 +73,8 @@

HeapVector<Member<CSSFontSelectorClient>> clients;

copyToVector(m_clients, clients);

- for (auto& client : clients) {

- // This should not be nullptr, but to see if checking nullptr can suppress

- // crashes. crbug.com/581698

- if (client)

- client->fontsNeedUpdate(this);

- }

+ for (auto& client : clients)

+ client->fontsNeedUpdate(this);

}

void CSSFontSelector::fontFaceInvalidated() {

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/FontCache.cpp » ('j') | no next file with comments »