Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/browser/download/download_create_info.h

Issue 2783473002: Fix issues and feature polishing for parallel download. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/download_request_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_create_info.h
diff --git a/content/browser/download/download_create_info.h b/content/browser/download/download_create_info.h
index 29f5256f13774ae0996deba395ab866457afa365..f5c11ea0a23e5b749fd27edaed9dd04c03ee53b1 100644
--- a/content/browser/download/download_create_info.h
+++ b/content/browser/download/download_create_info.h
@@ -64,12 +64,15 @@ struct CONTENT_EXPORT DownloadCreateInfo {
// presented or can't be parse, set to 0.
int64_t total_bytes;
- // The starting position of the request to save to the target file.
+ // The starting position of the initial request.
// This value matches the offset in DownloadSaveInfo.
- // TODO(xingliu): Remove this after we refactor DownloadJob to own
- // DownloadFile.
+ // TODO(xingliu): Refactor to remove |offset| and |length|.
int64_t offset;
+ // The length of the initial request.
+ // This value matches the length in DownloadSaveInfo.
+ int64_t length;
qinmin 2017/03/31 17:56:09 the initial request is always half open, right? wh
xingliu 2017/03/31 21:46:10 Done, addressed in https://codereview.chromium.org
+
// True if the download was initiated by user action.
bool has_user_gesture;
« no previous file with comments | « no previous file | content/browser/download/download_request_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698