Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2783443002: Fix for #29003 (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for #29003 This is an alternative to the other CL. It just uses the result of dart.mixin instead of declaring a new class. That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object. We were also not declaring interfaces for ClassTypeAliases. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/50ceaa4c04a99970158e5de3e410fb65cddfb2cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +37 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 9 months ago (2017-03-27 22:46:54 UTC) #3
Jennifer Messerly
lgtm
3 years, 9 months ago (2017-03-27 23:03:48 UTC) #4
vsm
3 years, 9 months ago (2017-03-27 23:06:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50ceaa4c04a99970158e5de3e410fb65cddfb2cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698