Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 2783233004: Refine tap disambiguation UMA to track same-node/different-node. (Closed)
Patch Set: Deprecate existing field Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 1244 matching lines...) Expand 10 before | Expand all | Expand 10 after
1255 IPC_MESSAGE_HANDLER(ViewMsg_DisableAutoResize, OnDisableAutoResize) 1255 IPC_MESSAGE_HANDLER(ViewMsg_DisableAutoResize, OnDisableAutoResize)
1256 IPC_MESSAGE_HANDLER(ViewMsg_DisableScrollbarsForSmallWindows, 1256 IPC_MESSAGE_HANDLER(ViewMsg_DisableScrollbarsForSmallWindows,
1257 OnDisableScrollbarsForSmallWindows) 1257 OnDisableScrollbarsForSmallWindows)
1258 IPC_MESSAGE_HANDLER(ViewMsg_SetRendererPrefs, OnSetRendererPrefs) 1258 IPC_MESSAGE_HANDLER(ViewMsg_SetRendererPrefs, OnSetRendererPrefs)
1259 IPC_MESSAGE_HANDLER(ViewMsg_MediaPlayerActionAt, OnMediaPlayerActionAt) 1259 IPC_MESSAGE_HANDLER(ViewMsg_MediaPlayerActionAt, OnMediaPlayerActionAt)
1260 IPC_MESSAGE_HANDLER(ViewMsg_PluginActionAt, OnPluginActionAt) 1260 IPC_MESSAGE_HANDLER(ViewMsg_PluginActionAt, OnPluginActionAt)
1261 IPC_MESSAGE_HANDLER(ViewMsg_SetActive, OnSetActive) 1261 IPC_MESSAGE_HANDLER(ViewMsg_SetActive, OnSetActive)
1262 IPC_MESSAGE_HANDLER(ViewMsg_ShowContextMenu, OnShowContextMenu) 1262 IPC_MESSAGE_HANDLER(ViewMsg_ShowContextMenu, OnShowContextMenu)
1263 IPC_MESSAGE_HANDLER(ViewMsg_ReleaseDisambiguationPopupBitmap, 1263 IPC_MESSAGE_HANDLER(ViewMsg_ReleaseDisambiguationPopupBitmap,
1264 OnReleaseDisambiguationPopupBitmap) 1264 OnReleaseDisambiguationPopupBitmap)
1265 IPC_MESSAGE_HANDLER(ViewMsg_ResolveTapDisambiguation,
1266 OnResolveTapDisambiguation)
1265 IPC_MESSAGE_HANDLER(ViewMsg_ForceRedraw, OnForceRedraw) 1267 IPC_MESSAGE_HANDLER(ViewMsg_ForceRedraw, OnForceRedraw)
1266 IPC_MESSAGE_HANDLER(ViewMsg_SelectWordAroundCaret, OnSelectWordAroundCaret) 1268 IPC_MESSAGE_HANDLER(ViewMsg_SelectWordAroundCaret, OnSelectWordAroundCaret)
1267 1269
1268 // Page messages. 1270 // Page messages.
1269 IPC_MESSAGE_HANDLER(PageMsg_UpdateWindowScreenRect, 1271 IPC_MESSAGE_HANDLER(PageMsg_UpdateWindowScreenRect,
1270 OnUpdateWindowScreenRect) 1272 OnUpdateWindowScreenRect)
1271 IPC_MESSAGE_HANDLER(PageMsg_SetZoomLevel, OnSetZoomLevel) 1273 IPC_MESSAGE_HANDLER(PageMsg_SetZoomLevel, OnSetZoomLevel)
1272 IPC_MESSAGE_HANDLER(PageMsg_SetDeviceScaleFactor, OnSetDeviceScaleFactor); 1274 IPC_MESSAGE_HANDLER(PageMsg_SetDeviceScaleFactor, OnSetDeviceScaleFactor);
1273 IPC_MESSAGE_HANDLER(PageMsg_WasHidden, OnPageWasHidden) 1275 IPC_MESSAGE_HANDLER(PageMsg_WasHidden, OnPageWasHidden)
1274 IPC_MESSAGE_HANDLER(PageMsg_WasShown, OnPageWasShown) 1276 IPC_MESSAGE_HANDLER(PageMsg_WasShown, OnPageWasShown)
(...skipping 1368 matching lines...) Expand 10 before | Expand all | Expand 10 after
2643 } 2645 }
2644 2646
2645 void RenderViewImpl::OnReleaseDisambiguationPopupBitmap( 2647 void RenderViewImpl::OnReleaseDisambiguationPopupBitmap(
2646 const cc::SharedBitmapId& id) { 2648 const cc::SharedBitmapId& id) {
2647 BitmapMap::iterator it = disambiguation_bitmaps_.find(id); 2649 BitmapMap::iterator it = disambiguation_bitmaps_.find(id);
2648 DCHECK(it != disambiguation_bitmaps_.end()); 2650 DCHECK(it != disambiguation_bitmaps_.end());
2649 delete it->second; 2651 delete it->second;
2650 disambiguation_bitmaps_.erase(it); 2652 disambiguation_bitmaps_.erase(it);
2651 } 2653 }
2652 2654
2655 void RenderViewImpl::OnResolveTapDisambiguation(double timestamp_seconds,
2656 gfx::Point tap_viewport_offset,
2657 bool is_long_press) {
2658 webview()->resolveTapDisambiguation(timestamp_seconds, tap_viewport_offset,
2659 is_long_press);
2660 }
2661
2653 void RenderViewImpl::DidCommitCompositorFrame() { 2662 void RenderViewImpl::DidCommitCompositorFrame() {
2654 RenderWidget::DidCommitCompositorFrame(); 2663 RenderWidget::DidCommitCompositorFrame();
2655 for (auto& observer : observers_) 2664 for (auto& observer : observers_)
2656 observer.DidCommitCompositorFrame(); 2665 observer.DidCommitCompositorFrame();
2657 } 2666 }
2658 2667
2659 void RenderViewImpl::SendUpdateFaviconURL(const std::vector<FaviconURL>& urls) { 2668 void RenderViewImpl::SendUpdateFaviconURL(const std::vector<FaviconURL>& urls) {
2660 if (!urls.empty()) 2669 if (!urls.empty())
2661 Send(new ViewHostMsg_UpdateFaviconURL(GetRoutingID(), urls)); 2670 Send(new ViewHostMsg_UpdateFaviconURL(GetRoutingID(), urls));
2662 } 2671 }
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
2713 INPUT_EVENT_ACK_STATE_NOT_CONSUMED); 2722 INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
2714 } 2723 }
2715 2724
2716 std::unique_ptr<InputEventAck> ack( 2725 std::unique_ptr<InputEventAck> ack(
2717 new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type(), 2726 new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type(),
2718 INPUT_EVENT_ACK_STATE_NOT_CONSUMED)); 2727 INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
2719 OnInputEventAck(std::move(ack)); 2728 OnInputEventAck(std::move(ack));
2720 } 2729 }
2721 2730
2722 } // namespace content 2731 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698