Replace ExtensionInstallChecker with generic PreloadCheckGroup

extensions/browser/preload_check_test_util.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_PRELOAD_CHECK_TEST_UTIL_H_
 #define EXTENSIONS_BROWSER_PRELOAD_CHECK_TEST_UTIL_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 12 matching lines @@
  public:
   PreloadCheckRunner();
   virtual ~PreloadCheckRunner();
 
   // Starts the check, providing OnCheckComplete as the callback.
   void Run(PreloadCheck* check);
 
   // Starts the check and waits for its callback to execute.
   void RunUntilComplete(PreloadCheck* check);
 
-  // Runs the message loop until OnCheckComplete is called.
-  void WaitForCompletion();
-
   // Runs the message loop until idle. Useful to see whether OnCheckComplete is
   // called without waiting indefinitely.
   void WaitForIdle();
 
+  // Runs the message loop until OnCheckComplete is called.
+  void WaitForComplete();
+
   PreloadCheck::ResultCallback GetCallback();
 
   const PreloadCheck::Errors& errors() const { return errors_; }
   bool called() const { return called_; }
 
  private:
   void OnCheckComplete(PreloadCheck::Errors errors);
 
   PreloadCheck::Errors errors_;
   bool called_;
 
   // Using a RunLoop data member would trigger tricky timing troubles.
   std::unique_ptr<base::RunLoop> run_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(PreloadCheckRunner);
 };
 
-// Stub for a PreloadCheck that returns the desired error(s).
+// Stub for a PreloadCheck that calls the callback with the given error(s).
 class PreloadCheckStub : public PreloadCheck {
  public:
-  PreloadCheckStub();
+  explicit PreloadCheckStub(const Errors& errors = Errors());

[Devlin, 2017/04/06 02:03:53]

nit: I'd prefer we don't use default arguments on non-POD data.  Let's keep
either a SetErrors() method, or pass in an empty array in cases of no error.

[michaelpg, 2017/04/06 22:31:16]

Done.

   ~PreloadCheckStub() override;
 
-  void AddError(Error error);
-  void set_error_message(const base::string16& message) { message_ = message; }
-
-  bool is_async() const { return is_async_; }
   void set_is_async(bool is_async) { is_async_ = is_async; }
+  bool started() const { return started_; }
 
   // PreloadCheck:
   void Start(ResultCallback callback) override;
-  base::string16 GetErrorMessage() const override;
 
  private:
   void RunCallback(ResultCallback callback);
 
   bool is_async_ = false;
+  bool started_ = false;
   Errors errors_;
-  base::string16 message_;
 
   base::WeakPtrFactory<PreloadCheckStub> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PreloadCheckStub);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_PRELOAD_CHECK_TEST_UTIL_H_