Replace ExtensionInstallChecker with generic PreloadCheckGroup

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "components/sync/model/string_ordinal.h"
 #include "extensions/browser/install_flag.h"
+#include "extensions/browser/preload_check.h"
 #include "extensions/browser/sandboxed_unpacker.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 
 class ExtensionService;
 class ExtensionServiceTest;
 class SkBitmap;
 struct WebApplicationInfo;
 
 namespace base {
 class SequencedTaskRunner;
 }
 
 namespace extensions {
 class CrxInstallError;
-class ExtensionInstallChecker;
 class ExtensionUpdaterTest;
+class PreloadCheckGroup;
 
 // This class installs a crx file into a profile.
 //
 // Installing a CRX is a multi-step process, including unpacking the crx,
 // validating it, prompting the user, and installing. Since many of these
 // steps must occur on the file thread, this class contains a copy of all data
 // necessary to do its job. (This also minimizes external dependencies for
 // easier testing).
 //
 // Lifetime management:
@@ skipping 182 matching lines @@
   void OnUnpackSuccess(const base::FilePath& temp_dir,
                        const base::FilePath& extension_dir,
                        std::unique_ptr<base::DictionaryValue> original_manifest,
                        const Extension* extension,
                        const SkBitmap& install_icon) override;
 
   // Called on the UI thread to start the requirements, policy and blacklist
   // checks on the extension.
   void CheckInstall();
 
-  // Runs on the UI thread. Callback from ExtensionInstallChecker.
-  void OnInstallChecksComplete(int failed_checks);
+  // Runs on the UI thread. Callback from PreloadCheckGroup.
+  void OnInstallChecksComplete(PreloadCheck::Errors errors);
 
   // Runs on the UI thread. Confirms the installation to the ExtensionService.
   void ConfirmInstall();
 
   // Runs on the UI thread. Updates the creation flags for the extension and
   // calls CompleteInstall().
   void UpdateCreationFlagsAndCompleteInstall();
 
   // Runs on File thread. Install the unpacked extension into the profile and
   // notify the frontend.
@@ skipping 177 matching lines @@
   // Used to show the install dialog.
   ExtensionInstallPrompt::ShowDialogCallback show_dialog_callback_;
 
   // Whether the update is initiated by the user from the extension settings
   // page.
   bool update_from_settings_page_;
 
   // The flags for ExtensionService::OnExtensionInstalled.
   int install_flags_;
 
-  // Performs requirements, policy and blacklist checks on the extension.
-  std::unique_ptr<ExtensionInstallChecker> install_checker_;
+  // Checks that may run before installing the extension.
+  std::unique_ptr<PreloadCheck> policy_check_;
+  std::unique_ptr<PreloadCheck> requirements_check_;
+  std::unique_ptr<PreloadCheck> blacklist_check_;
+
+  // Runs the above checks.
+  std::unique_ptr<PreloadCheckGroup> check_group_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_