third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen.html - Issue 2783133002: Implement Image::maybeAnimated for SVGImage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen.html

Issue 2783133002: Implement Image::maybeAnimated for SVGImage (Closed)

Patch Set: Fix typo Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/invalidation/svg/animated-svg-as-image-background-offscreen-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/text-based-repaint.js"></script>

	3 <script>

	4 window.testIsAsync = true;

	5

	6 // Disable under-invalidation checking because the "under-invalidation" of

	7 // offscreen SVG animation is intentional.

	8 if (window.internals)

	9 internals.runtimeFlags.paintUnderInvalidationCheckingEnabled = false;

	10

	11 function repaintTest() {

	12 if (window.internals)

	13 internals.advanceImageAnimation(testTarget);

	14 requestAnimationFrame(function() {

	15 finishRepaintTest();

	16 });

	17 }

	18

	19 function targetImageOnload() {

	20 // Scroll targetImage offscreen.

	21 window.scrollTo(0, 1000);

	22 runRepaintTest();

	23 }

	24

	25 window.onload = function() {

	26 targetImage.style.background = "url(../../../svg/as-image/resources/animated -rect-fixed-size-2.svg)";
	chrishtr 2017/03/30 15:42:35 Does this sufficiently test the case of an animate Does this sufficiently test the case of an animated LayoutBox background? I guess image backgrounds go through the LayoutBox code for invalidation? fs 2017/03/31 10:32:46 Yes, this should trigger the code in LayoutBox::im Show quoted text On 2017/03/30 at 15:42:35, chrishtr wrote: > Does this sufficiently test the case of an animated LayoutBox background? > I guess image backgrounds go through the LayoutBox code for invalidation? Yes, this should trigger the code in LayoutBox::imageChanged.
	27

	28 // Use a parallel image element as a hack to detect whether the image has lo aded, and therefore

	29 // we'll get a frame.
	chrishtr 2017/03/30 15:42:35 onload events don't work for SVG Images? Weird. Wh onload events don't work for SVG Images? Weird. Why is that? Is it something that should be fixed in the platform? I googled around and found this hack: http://stackoverflow.com/questions/11390830/is-it-possible-to-listen-image-lo... Does it work for this test? fs 2017/03/31 10:32:46 They do, but for background images you won't get a Show quoted text On 2017/03/30 at 15:42:35, chrishtr wrote: > onload events don't work for SVG Images? Weird. Why is that? Is it something > that should be fixed in the platform? They do, but for background images you won't get a notification. (I guess latching onto document 'load' could work...) Show quoted text > I googled around and found this hack: > > http://stackoverflow.com/questions/11390830/is-it-possible-to-listen-image-lo... > > Does it work for this test? This is unrelated. (That's for <svg:image> which is like <img>.)
	30 testTarget.onload = targetImageOnload;

	31 testTarget.src = "../../../svg/as-image/resources/animated-rect-fixed-size-2 .svg";

	32 }

	33 </script>

	34 <div style="height: 2000px; width: 2000px;">

	35 <div id="targetImage" style="width: 50px; height: 50px"></div>

	36 <img id="testTarget" style="visibility: hidden">

	37 </div>

OLD	NEW