Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 278303002: Fix the "call to 'abs' is ambiguous" error in line 42 (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Fix the "call to 'abs' is ambiguous" error in line 42 std::abs() for integers is declared in <cstdlib>, not <cmath> R=pkotwicz@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/wm/workspace/two_step_edge_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexander Potapenko
Please take a look.
6 years, 7 months ago (2014-05-12 09:10:47 UTC) #1
pkotwicz
LGTM
6 years, 7 months ago (2014-05-12 15:16:41 UTC) #2
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-13 08:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/278303002/1
6 years, 7 months ago (2014-05-13 08:49:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 10:41:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 11:09:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153381)
6 years, 7 months ago (2014-05-13 11:09:35 UTC) #7
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-13 11:11:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/278303002/1
6 years, 7 months ago (2014-05-13 11:11:25 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 13:19:13 UTC) #10
Message was sent while issue was closed.
Change committed as 270082

Powered by Google App Engine
This is Rietveld 408576698