chrome/browser/ui/views/chrome_views_delegate.cc - Issue 2783023002: Use an InsetMetric instead of a constant for vector button padding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 2783023002: Use an InsetMetric instead of a constant for vector button padding. (Closed)

Patch Set: revert the stuff that got mixed in from another patch Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/chrome_views_delegate.cc

diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc

index 9f5c82dc86c4fd8a387099e21c780b3199af7ed9..cba7d894e4a81b55a41dbb03be52cf1b9b9a0fe2 100644

--- a/chrome/browser/ui/views/chrome_views_delegate.cc

+++ b/chrome/browser/ui/views/chrome_views_delegate.cc

@@ -231,6 +231,9 @@ gfx::Insets ChromeViewsDelegate::GetInsetsMetric(

case views::InsetsMetric::BUBBLE_DIALOG:

return gfx::Insets(layout_delegate->GetMetric(

LayoutDelegate::Metric::PANEL_CONTENT_MARGIN));

+ case views::InsetsMetric::VECTOR_IMAGE_BUTTON_PADDING:

+ return gfx::Insets(layout_delegate->GetMetric(

+ LayoutDelegate::Metric::VECTOR_IMAGE_BUTTON_PADDING));

}

NOTREACHED();

return gfx::Insets();