Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Side by Side Diff: ui/views/views_delegate.h

Issue 2783023002: Use an InsetMetric instead of a constant for vector button padding. (Closed)
Patch Set: revert the stuff that got mixed in from another patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_VIEWS_DELEGATE_H_ 5 #ifndef UI_VIEWS_VIEWS_DELEGATE_H_
6 #define UI_VIEWS_VIEWS_DELEGATE_H_ 6 #define UI_VIEWS_VIEWS_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 enum class InsetsMetric { 65 enum class InsetsMetric {
66 // The margins that should be applied around a bubble dialog. 66 // The margins that should be applied around a bubble dialog.
67 BUBBLE_DIALOG, 67 BUBBLE_DIALOG,
68 // The insets that should be applied around a DialogClientView. Note that 68 // The insets that should be applied around a DialogClientView. Note that
69 // the top inset is used for the distance between the buttons and the 69 // the top inset is used for the distance between the buttons and the
70 // DialogClientView's content view. 70 // DialogClientView's content view.
71 DIALOG_BUTTON, 71 DIALOG_BUTTON,
72 // The insets that should be applied around a dialog's frame view. 72 // The insets that should be applied around a dialog's frame view.
73 DIALOG_FRAME_VIEW, 73 DIALOG_FRAME_VIEW,
74 // Padding to add to vector image buttons to increase their click and touch
75 // target size.
76 VECTOR_IMAGE_BUTTON_PADDING,
74 }; 77 };
75 78
76 enum class DistanceMetric { 79 enum class DistanceMetric {
77 // The default padding to add on each side of a button's label. 80 // The default padding to add on each side of a button's label.
78 BUTTON_HORIZONTAL_PADDING, 81 BUTTON_HORIZONTAL_PADDING,
79 // The distance between a dialog's edge and the close button in the upper 82 // The distance between a dialog's edge and the close button in the upper
80 // trailing corner. 83 // trailing corner.
81 CLOSE_BUTTON_MARGIN, 84 CLOSE_BUTTON_MARGIN,
82 // The default minimum width of a dialog button. 85 // The default minimum width of a dialog button.
83 DIALOG_BUTTON_MINIMUM_WIDTH, 86 DIALOG_BUTTON_MINIMUM_WIDTH,
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 #endif 273 #endif
271 274
272 NativeWidgetFactory native_widget_factory_; 275 NativeWidgetFactory native_widget_factory_;
273 276
274 DISALLOW_COPY_AND_ASSIGN(ViewsDelegate); 277 DISALLOW_COPY_AND_ASSIGN(ViewsDelegate);
275 }; 278 };
276 279
277 } // namespace views 280 } // namespace views
278 281
279 #endif // UI_VIEWS_VIEWS_DELEGATE_H_ 282 #endif // UI_VIEWS_VIEWS_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698