ui/views/layout/layout_constants.h - Issue 2783023002: Use an InsetMetric instead of a constant for vector button padding.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/layout/layout_constants.h

Issue 2783023002: Use an InsetMetric instead of a constant for vector button padding. (Closed)

Patch Set: revert the stuff that got mixed in from another patch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/views/controls/button/image_button_factory.cc ('k') | ui/views/views_delegate.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_	5 #ifndef UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_

6 #define UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_	6 #define UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9 #include "ui/views/layout/grid_layout.h"	9 #include "ui/views/layout/grid_layout.h"

10	10

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85	85

86 // Padding on the left and right of a button's contents.	86 // Padding on the left and right of a button's contents.

87 const int kButtonHorizontalPadding = 16;	87 const int kButtonHorizontalPadding = 16;

88	88

89 // Default minimum width of buttons.	89 // Default minimum width of buttons.

90 const int kMinimumButtonWidth = 48;	90 const int kMinimumButtonWidth = 48;

91	91

92 // Minimum width of dialog buttons.	92 // Minimum width of dialog buttons.

93 constexpr int kDialogMinimumButtonWidth = 75;	93 constexpr int kDialogMinimumButtonWidth = 75;

94	94

	95 // Extra space around vector buttons to increase their event target size.

	96 constexpr int kVectorButtonExtraTouchSize = 4;
	sky 2017/03/29 23:45:31 If you add this constant here how do you prevent p If you add this constant here how do you prevent people from using it directly? Don't you want code to use the InsetsMetric::VECTOR_IMAGE_BUTTON_PADDING? Peter Kasting 2017/03/29 23:47:21 I think the answer is "Allen's refactoring lands a Show quoted text On 2017/03/29 23:45:31, sky wrote: > If you add this constant here how do you prevent people from using it directly? > Don't you want code to use the InsetsMetric::VECTOR_IMAGE_BUTTON_PADDING? I think the answer is "Allen's refactoring lands and this file goes away, and the layout delegate becomes the only way to get at anything". Bret 2017/03/29 23:52:00 Right, since we're moving towards deleting this fi Show quoted text On 2017/03/29 23:47:21, Peter Kasting wrote: > On 2017/03/29 23:45:31, sky wrote: > > If you add this constant here how do you prevent people from using it > directly? > > Don't you want code to use the InsetsMetric::VECTOR_IMAGE_BUTTON_PADDING? > > I think the answer is "Allen's refactoring lands and this file goes away, and > the layout delegate becomes the only way to get at anything". Right, since we're moving towards deleting this file I'd rather move constants into it so they go away as part of the refactor.
	97

95 } // namespace views	98 } // namespace views

96	99

97 #endif // UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_	100 #endif // UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_

OLD	NEW