DevTools: Make EntryHighlighted an event rather than method on data provider

third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 486 matching lines @@
     if (warning) {
       warning.classList.add('timeline-info-warning');
       contents.appendChild(warning);
     }
     return element;
   }
 
   /**
    * @override
    * @param {number} entryIndex
-   */
-  highlightEntry(entryIndex) {
-    SDK.DOMModel.hideDOMNodeHighlight();
-    if (this._entryType(entryIndex) !== Timeline.TimelineFlameChartEntryType.Event)
-      return;
-    var event = /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]);
-    var target = this._model.targetByEvent(event);
-    if (!target)
-      return;
-    var timelineData = TimelineModel.TimelineData.forEvent(event);
-    var backendNodeId = timelineData.backendNodeId;
-    if (!backendNodeId)
-      return;
-    new SDK.DeferredDOMNode(target, backendNodeId).highlight();
-  }
-
-  /**
-   * @override
-   * @param {number} entryIndex
    * @return {string}
    */
   entryColor(entryIndex) {
     // This is not annotated due to closure compiler failure to properly infer cache container's template type.
     function patchColorAndCache(cache, key, lookupColor) {
       var color = cache.get(key);
       if (color)
         return color;
       var parsedColor = Common.Color.parse(lookupColor(key));
       color = parsedColor.setAlpha(0.7).asString(Common.Color.Format.RGBA) || '';
@@ skipping 340 matching lines @@
   }
 
   /**
    * @param {number} entryIndex
    * @return {boolean}
    */
   buildFlowForInitiator(entryIndex) {
     if (this._lastInitiatorEntry === entryIndex)
       return false;
     this._lastInitiatorEntry = entryIndex;
-    var event = this._entryType(entryIndex) === Timeline.TimelineFlameChartEntryType.Event ?
-        /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]) :
-        null;
-    var td = this._timelineData;
+    var event = this.eventByIndex(entryIndex);
     var initiator = event && TimelineModel.TimelineData.forEvent(event).initiator();
     if (initiator && !this._isVisible(initiator))
       initiator = null;
+    var td = this._timelineData;
     if (td.flowStartTimes.length || initiator) {
       td.flowStartTimes = [];
       td.flowStartLevels = [];
       td.flowEndTimes = [];
       td.flowEndLevels = [];
     }
     if (!initiator)
       return true;
     var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._indexSymbol];
     var eventIndex = event[Timeline.TimelineFlameChartDataProvider._indexSymbol];
     td.flowStartTimes.push(initiator.endTime || initiator.startTime);
     td.flowStartLevels.push(td.entryLevels[initiatorIndex]);
     td.flowEndTimes.push(event.startTime);
     td.flowEndLevels.push(td.entryLevels[eventIndex]);
     return true;
   }
+
+  /**
+   * @param {number} entryIndex
+   * @return {?SDK.TracingModel.Event}
+   */
+  eventByIndex(entryIndex) {
+    return this._entryType(entryIndex) === Timeline.TimelineFlameChartEntryType.Event ?
+        /** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]) :
+        null;
+  }
 };
 
 Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs = 0.001;
 Timeline.TimelineFlameChartDataProvider._indexSymbol = Symbol('index');