Issue 2782913003: Revert "Remove definitions from Kernel canonical names."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2782913003: Revert "Remove definitions from Kernel canonical names." (Closed)

Created:
3 years, 8 months ago by zra

Modified:
3 years, 8 months ago

Reviewers:
Florian Schneider, Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove definitions from Kernel canonical names." This reverts commit ed77783cd32d55fdad61bf9bc749030847ba9384. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a7d1d99389924e930be4d033559aa678084ce3aa

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+352 lines, -409 lines)			Patch
M	pkg/kernel/lib/ast.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/canonical_name.dart	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/kernel.h	View	27 chunks	+89 lines, -46 lines	0 comments	Download
M	runtime/vm/kernel.cc	View	18 chunks	+69 lines, -133 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View	7 chunks	+24 lines, -6 lines	0 comments	Download
M	runtime/vm/kernel_reader.cc	View	7 chunks	+13 lines, -18 lines	0 comments	Download
M	runtime/vm/kernel_to_il.h	View	5 chunks	+16 lines, -32 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View	27 chunks	+140 lines, -166 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 8 months ago (2017-03-29 18:25:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a7d1d99389924e930be4d033559aa678084ce3aa (presubmit successful).