Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2782903002: Disable sending persistent histograms from last session by default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 65f7d09014d5c0db89b6b3eae299df31003815b8..703185bcbe25f694a3cba5f8618133499f0be9af 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -210,9 +210,15 @@ std::unique_ptr<metrics::FileMetricsProvider> CreateFileMetricsProvider(
base::FilePath user_data_dir;
if (base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
- // Register the file holding browser metrics.
+ // Reporting of persistent histograms from last session is controlled by
+ // a feature param. TODO(bcwhite): The current default is not to upload
+ // until some issues are resolved. See crbug.com/706422 for details.
+ std::string send_unreported = variations::GetVariationParamValueByFeature(
+ base::kPersistentHistogramsFeature, "send_unreported_metrics");
+ boolean report_previous_persistent_histograms =
bcwhite 2017/03/29 16:09:12 boolean => bool
Alexei Svitkine (slow) 2017/03/29 16:19:01 Oops, teaches for sending right before lunch befor
+ metrics_reporting_enabled && (send_unreported == "yes");
RegisterOrRemovePreviousRunMetricsFile(
- metrics_reporting_enabled, user_data_dir,
+ report_previous_persistent_histograms, user_data_dir,
ChromeMetricsServiceClient::kBrowserMetricsName, task_runner,
file_metrics_provider.get());
« no previous file with comments | « no previous file | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698