Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index f89ecf2332a07dbb2d6aadc01d3cdabb2ebdbe01..d7c8533be788fdfc496d037ec9710d407020c725 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -2542,8 +2542,7 @@ TEST_P(WebViewTest, BlinkCaretOnClosingContextMenu) {
WebInputEvent::TimeStampForTesting);
mouseEvent.button = WebMouseEvent::Button::Right;
- mouseEvent.x = 1;
- mouseEvent.y = 1;
+ mouseEvent.setPositionInWidget(1, 1);
mouseEvent.clickCount = 1;
webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
runPendingTasks();
@@ -3589,8 +3588,7 @@ TEST_P(WebViewTest, FirstUserGestureObservedMouseEvent) {
WebMouseEvent mouseEvent(WebInputEvent::MouseDown, WebInputEvent::NoModifiers,
WebInputEvent::TimeStampForTesting);
mouseEvent.button = WebMouseEvent::Button::Left;
- mouseEvent.x = 1;
- mouseEvent.y = 1;
+ mouseEvent.setPositionInWidget(1, 1);
mouseEvent.clickCount = 1;
webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
mouseEvent.setType(WebInputEvent::MouseUp);
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp ('k') | third_party/WebKit/public/platform/WebGestureEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698