third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

index e2e57a32eac8e6861754ae9f417a530a151c1f90..7f3ad4f065a5bce73027e0f649ea1fb3b3f9d57b 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

@@ -147,8 +147,8 @@ WebMouseEvent createMouseEvent(WebInputEvent::Type type,

const IntPoint& point,

int modifiers) {

WebMouseEvent result(type, modifiers, WebInputEvent::TimeStampForTesting);

- result.x = result.globalX = point.x();

- result.y = result.globalX = point.y();

+ result.setPositionInWidget(point.x(), point.y());

+ result.setPositionInScreen(point.x(), point.y());

result.button = button;

result.clickCount = 1;

return result;