Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 81155527bea5ed9421c0ec6609f20f20df1abc89..8d85f6757296f8fb816925e740a7b09eff31ad3d 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -484,7 +484,8 @@ WebInputEventResult WebPagePopupImpl::handleGestureEvent(
void WebPagePopupImpl::handleMouseDown(LocalFrame& mainFrame,
const WebMouseEvent& event) {
- if (isViewportPointInWindow(event.x, event.y))
+ if (isViewportPointInWindow(event.positionInWidget().x,
+ event.positionInWidget().y))
PageWidgetEventHandler::handleMouseDown(mainFrame, event);
else
cancel();
@@ -493,7 +494,8 @@ void WebPagePopupImpl::handleMouseDown(LocalFrame& mainFrame,
WebInputEventResult WebPagePopupImpl::handleMouseWheel(
LocalFrame& mainFrame,
const WebMouseWheelEvent& event) {
- if (isViewportPointInWindow(event.x, event.y))
+ if (isViewportPointInWindow(event.positionInWidget().x,
+ event.positionInWidget().y))
return PageWidgetEventHandler::handleMouseWheel(mainFrame, event);
cancel();
return WebInputEventResult::NotHandled;
« no previous file with comments | « third_party/WebKit/Source/web/WebInputEventConversion.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698