Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandlerTest.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
index f8618151f6be13253f4f4efeefa617b8fe13d3b2..2161408f393ec7d446dfdfd76ba156d7e96eecda 100644
--- a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
@@ -65,7 +65,7 @@ class LongPressEventBuilder : public WebGestureEvent {
class MousePressEventBuilder : public WebMouseEvent {
public:
- MousePressEventBuilder(IntPoint position,
+ MousePressEventBuilder(IntPoint positionParam,
int clickCountParam,
WebMouseEvent::Button buttonParam)
: WebMouseEvent(WebInputEvent::MouseDown,
@@ -73,8 +73,8 @@ class MousePressEventBuilder : public WebMouseEvent {
TimeTicks::Now().InSeconds()) {
clickCount = clickCountParam;
button = buttonParam;
- x = globalX = position.x();
- y = globalY = position.y();
+ setPositionInWidget(positionParam.x(), positionParam.y());
+ setPositionInScreen(positionParam.x(), positionParam.y());
m_frameScale = 1;
}
};

Powered by Google App Engine
This is Rietveld 408576698