content/renderer/gpu/gpu_benchmarking_extension.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/gpu_benchmarking_extension.cc

diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc b/content/renderer/gpu/gpu_benchmarking_extension.cc

index ea33b0074b6dceb350dc6ef9208bd4c159839c9c..b4993edef69092c05126bca3671b0c5c331d8ea1 100644

--- a/content/renderer/gpu/gpu_benchmarking_extension.cc

+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc

@@ -361,8 +361,9 @@ bool BeginSmoothScroll(v8::Isolate* isolate,

blink::WebMouseEvent mouseMove(

blink::WebInputEvent::MouseMove, blink::WebInputEvent::NoModifiers,

ui::EventTimeStampToSeconds(ui::EventTimeForNow()));

- mouseMove.x = (contentRect.x + contentRect.width / 2) * page_scale_factor;

- mouseMove.y = (contentRect.y + contentRect.height / 2) * page_scale_factor;

+ mouseMove.setPositionInWidget(

+ (contentRect.x + contentRect.width / 2) * page_scale_factor,

+ (contentRect.y + contentRect.height / 2) * page_scale_factor);

context.web_view()->handleInputEvent(

blink::WebCoalescedInputEvent(mouseMove));

context.web_view()->setCursorVisibilityState(true);