content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_mac.mm ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

diff --git a/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm b/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

index cd1b40cbdc5b7d8802643cbca3988a9c7106b27a..d8049068e33d14d64f5605aa438063f93951a994 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

+++ b/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm

@@ -609,11 +609,11 @@ TEST(WebInputEventBuilderMacTest, ScrollWheelMatchesUIEvent) {

EXPECT_EQ(delta_y * ui::kScrollbarPixelsPerCocoaTick, web_event.deltaY);

EXPECT_EQ(web_event.deltaY, ui_event.y_offset());

- EXPECT_EQ(11, web_event.x);

- EXPECT_EQ(web_event.x, ui_event.x());

+ EXPECT_EQ(11, web_event.positionInWidget().x);

+ EXPECT_EQ(web_event.positionInWidget().x, ui_event.x());

// Both ui:: and blink:: events use an origin at the top-left.

- EXPECT_EQ(100 - 22, web_event.y);

- EXPECT_EQ(web_event.y, ui_event.y());

+ EXPECT_EQ(100 - 22, web_event.positionInWidget().y);

+ EXPECT_EQ(web_event.positionInWidget().y, ui_event.y());

[window close];

}