content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/render_widget_host_latency_tracker.cc ('k') | content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

index a161e2f0938b8dffdf03742c0d3906c14458f076..701e40262672fb8eb22085ab287d68bf1af5771b 100644

--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

@@ -671,8 +671,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {

{

auto event =

SyntheticWebMouseWheelEventBuilder::Build(0, 0, -5, 0, 0, true);

- event.x = 100;

- event.y = 200;

+ event.setPositionInWidget(100, 200);

ui::LatencyInfo latency_info;

tracker()->OnInputEvent(event, &latency_info);

EXPECT_EQ(1u, latency_info.input_coordinates_size());

@@ -682,8 +681,7 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {

{

auto event = SyntheticWebMouseEventBuilder::Build(WebInputEvent::MouseMove);

- event.x = 300;

- event.y = 400;

+ event.setPositionInWidget(300, 400);

ui::LatencyInfo latency_info;

tracker()->OnInputEvent(event, &latency_info);

EXPECT_EQ(1u, latency_info.input_coordinates_size());