content/browser/pointer_lock_browsertest.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/pointer_lock_browsertest.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_guest.cc ('k') | content/browser/renderer_host/input/input_router_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/pointer_lock_browsertest.cc

diff --git a/content/browser/pointer_lock_browsertest.cc b/content/browser/pointer_lock_browsertest.cc

index ad5e90c7b3a720ff629a6462df413cad796b30d7..f4b84211b5a7aed6f8dad87db6fa718e06a884f3 100644

--- a/content/browser/pointer_lock_browsertest.cc

+++ b/content/browser/pointer_lock_browsertest.cc

@@ -198,8 +198,7 @@ IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockEventRouting) {

blink::WebMouseEvent mouse_event(blink::WebInputEvent::MouseMove,

blink::WebInputEvent::NoModifiers,

blink::WebInputEvent::TimeStampForTesting);

- mouse_event.x = 10;

- mouse_event.y = 11;

+ mouse_event.setPositionInWidget(10, 11);

mouse_event.movementX = 12;

mouse_event.movementY = 13;

router->RouteMouseEvent(root_view, &mouse_event, ui::LatencyInfo());

@@ -246,8 +245,8 @@ IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockEventRouting) {

root_view->TransformPointToCoordSpaceForView(gfx::Point(0, 0), child_view,

&transformed_point);

- mouse_event.x = -transformed_point.x() + 14;

- mouse_event.y = -transformed_point.y() + 15;

+ mouse_event.setPositionInWidget(-transformed_point.x() + 14,

+ -transformed_point.y() + 15);

mouse_event.movementX = 16;

mouse_event.movementY = 17;

// We use root_view intentionally as the RenderWidgetHostInputEventRouter is

@@ -344,8 +343,7 @@ IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockWheelEventRouting) {

blink::WebMouseWheelEvent wheel_event(

blink::WebInputEvent::MouseWheel, blink::WebInputEvent::NoModifiers,

blink::WebInputEvent::TimeStampForTesting);

- wheel_event.x = 10;

- wheel_event.y = 11;

+ wheel_event.setPositionInWidget(10, 11);

wheel_event.deltaX = -12;

wheel_event.deltaY = -13;

router->RouteMouseWheelEvent(root_view, &wheel_event, ui::LatencyInfo());

@@ -393,8 +391,8 @@ IN_PROC_BROWSER_TEST_F(PointerLockBrowserTest, PointerLockWheelEventRouting) {

root_view->TransformPointToCoordSpaceForView(gfx::Point(0, 0), child_view,

&transformed_point);

- wheel_event.x = -transformed_point.x() + 14;

- wheel_event.y = -transformed_point.y() + 15;

+ wheel_event.setPositionInWidget(-transformed_point.x() + 14,

+ -transformed_point.y() + 15);

wheel_event.deltaX = -16;

wheel_event.deltaY = -17;

// We use root_view intentionally as the RenderWidgetHostInputEventRouter is