chrome/renderer/plugins/chrome_plugin_placeholder.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/plugins/chrome_plugin_placeholder.cc

diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.cc b/chrome/renderer/plugins/chrome_plugin_placeholder.cc

index 45bebb3a223a39249e322c29d28da899c55adbbe..5fd6df10eab3c61864e9840a5a889ff6ca6131b9 100644

--- a/chrome/renderer/plugins/chrome_plugin_placeholder.cc

+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.cc

@@ -330,7 +330,7 @@ void ChromePluginPlaceholder::ShowContextMenu(

hide_item.label = l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLUGIN_HIDE);

params.custom_items.push_back(hide_item);

- blink::WebPoint point(event.x, event.y);

+ blink::WebPoint point(event.positionInWidget().x, event.positionInWidget().y);

if (plugin() && plugin()->container())

point = plugin()->container()->localToRootFramePoint(point);