chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index 715627e552dd8d49536b957fb469e2faf142cad9..c3523a51d193efac3919de9da8e4996f2f0a98ed 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -573,8 +573,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, RequestOpenTab) {

blink::WebInputEvent::NoModifiers,

blink::WebInputEvent::TimeStampForTesting);

mouse_event.button = blink::WebMouseEvent::Button::Middle;

- mouse_event.x = 7;

- mouse_event.y = 7;

+ mouse_event.setPositionInWidget(7, 7);

mouse_event.clickCount = 1;

tab->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(mouse_event);

mouse_event.setType(blink::WebInputEvent::MouseUp);

@@ -606,8 +605,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, TargetBlank) {

blink::WebInputEvent::NoModifiers,

blink::WebInputEvent::TimeStampForTesting);

mouse_event.button = blink::WebMouseEvent::Button::Left;

- mouse_event.x = 7;

- mouse_event.y = 7;

+ mouse_event.setPositionInWidget(7, 7);

mouse_event.clickCount = 1;

tab->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(mouse_event);

mouse_event.setType(blink::WebInputEvent::MouseUp);

@@ -637,8 +635,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, TargetBlankIncognito) {

blink::WebInputEvent::NoModifiers,

blink::WebInputEvent::TimeStampForTesting);

mouse_event.button = blink::WebMouseEvent::Button::Left;

- mouse_event.x = 7;

- mouse_event.y = 7;

+ mouse_event.setPositionInWidget(7, 7);

mouse_event.clickCount = 1;

tab->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(mouse_event);

mouse_event.setType(blink::WebInputEvent::MouseUp);