Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Fixed a compile failure Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 3da48427e32fc09e84d5d2241567aa331573fe3b..ecc186b2d993d2b041ec9d61938b1361a16cc9a7 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -478,7 +478,8 @@ WebInputEventResult WebPagePopupImpl::handleGestureEvent(
void WebPagePopupImpl::handleMouseDown(LocalFrame& mainFrame,
const WebMouseEvent& event) {
- if (isViewportPointInWindow(event.x, event.y))
+ if (isViewportPointInWindow(event.positionInWidget().x,
+ event.positionInWidget().y))
PageWidgetEventHandler::handleMouseDown(mainFrame, event);
else
cancel();
@@ -487,7 +488,8 @@ void WebPagePopupImpl::handleMouseDown(LocalFrame& mainFrame,
WebInputEventResult WebPagePopupImpl::handleMouseWheel(
LocalFrame& mainFrame,
const WebMouseWheelEvent& event) {
- if (isViewportPointInWindow(event.x, event.y))
+ if (isViewportPointInWindow(event.positionInWidget().x,
+ event.positionInWidget().y))
return PageWidgetEventHandler::handleMouseWheel(mainFrame, event);
cancel();
return WebInputEventResult::NotHandled;

Powered by Google App Engine
This is Rietveld 408576698