Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Truncated to int on input, git cl format Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 7a229f3c9a29299a7b7e9ae5f6b2f48c1776aa80..95b4a2ca6ccd4f483f125cb4934ac2f3bee21796 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -2526,8 +2526,7 @@ TEST_P(WebViewTest, BlinkCaretOnClosingContextMenu) {
WebInputEvent::TimeStampForTesting);
mouseEvent.button = WebMouseEvent::Button::Right;
- mouseEvent.x = 1;
- mouseEvent.y = 1;
+ mouseEvent.setPositionInWidget(1, 1);
mouseEvent.clickCount = 1;
webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
runPendingTasks();
@@ -3573,8 +3572,7 @@ TEST_P(WebViewTest, FirstUserGestureObservedMouseEvent) {
WebMouseEvent mouseEvent(WebInputEvent::MouseDown, WebInputEvent::NoModifiers,
WebInputEvent::TimeStampForTesting);
mouseEvent.button = WebMouseEvent::Button::Left;
- mouseEvent.x = 1;
- mouseEvent.y = 1;
+ mouseEvent.setPositionInWidget(1, 1);
mouseEvent.clickCount = 1;
webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
mouseEvent.setType(WebInputEvent::MouseUp);

Powered by Google App Engine
This is Rietveld 408576698