content/browser/renderer_host/input/web_input_event_builders_android.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_android.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Truncated to int on input, git cl format Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc ('K') | « content/browser/renderer_host/input/touch_emulator_unittest.cc ('k') | content/browser/renderer_host/input/web_input_event_builders_mac.mm » ('j') | content/browser/renderer_host/input/web_input_event_builders_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_android.cc

diff --git a/content/browser/renderer_host/input/web_input_event_builders_android.cc b/content/browser/renderer_host/input/web_input_event_builders_android.cc

index bd6fff7a43958a13151cbd143fb231327b92c5e3..237fb64a210fae5533b0b620898b8c490239fa9d 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_android.cc

+++ b/content/browser/renderer_host/input/web_input_event_builders_android.cc

@@ -127,8 +127,7 @@ WebMouseEvent WebMouseEventBuilder::Build(WebInputEvent::Type type,

WebMouseEvent result(type, ui::EventFlagsToWebEventModifiers(modifiers),

time_sec);

- result.x = window_x;

- result.y = window_y;

+ result.setPositionInWidget(window_x, window_y);

result.clickCount = click_count;

int button = action_button;

@@ -160,8 +159,7 @@ WebMouseWheelEvent WebMouseWheelEventBuilder::Build(float ticks_x,

int window_y) {

WebMouseWheelEvent result(WebInputEvent::MouseWheel,

WebInputEvent::NoModifiers, time_sec);

- result.x = window_x;

- result.y = window_y;

+ result.setPositionInWidget(window_x, window_y);

result.button = WebMouseEvent::Button::NoButton;

result.hasPreciseScrollingDeltas = true;

result.deltaX = ticks_x * tick_multiplier;