chrome/browser/android/vr_shell/vr_shell_gl.cc - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_shell_gl.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Truncated to int on input, git cl format Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_shell_gl.cc

diff --git a/chrome/browser/android/vr_shell/vr_shell_gl.cc b/chrome/browser/android/vr_shell/vr_shell_gl.cc

index 04576097918cdeb873940654a892d8a31229dee4..197f9e648ae82f5e541ced380d94c49edda4af6a 100644

--- a/chrome/browser/android/vr_shell/vr_shell_gl.cc

+++ b/chrome/browser/android/vr_shell/vr_shell_gl.cc

@@ -117,8 +117,7 @@ std::unique_ptr<blink::WebMouseEvent> MakeMouseEvent(WebInputEvent::Type type,

std::unique_ptr<blink::WebMouseEvent> mouse_event(new blink::WebMouseEvent(

type, blink::WebInputEvent::NoModifiers, timestamp));

mouse_event->pointerType = blink::WebPointerProperties::PointerType::Mouse;

- mouse_event->x = x;

- mouse_event->y = y;

+ mouse_event->setPositionInWidget(x, y);

mouse_event->clickCount = 1;

return mouse_event;