Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)
Patch Set: Fixed compile failures. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index 66c916c6174f8a595f88af43df3aeea77ff9f0a7..2263ed384518a934ae9f86c902ac676a3f2f33c4 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -309,11 +309,11 @@ class LeftMouseClick {
DCHECK(click_completed_);
click_completed_ = false;
mouse_event_.setType(blink::WebInputEvent::MouseDown);
- mouse_event_.x = point.x();
- mouse_event_.y = point.y();
+ mouse_event_.position.x = point.x();
+ mouse_event_.position.y = point.y();
const gfx::Rect offset = web_contents_->GetContainerBounds();
- mouse_event_.globalX = point.x() + offset.x();
- mouse_event_.globalY = point.y() + offset.y();
+ mouse_event_.screenPosition.x = point.x() + offset.x();
+ mouse_event_.screenPosition.y = point.y() + offset.y();
mouse_event_.clickCount = 1;
web_contents_->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(
mouse_event_);
@@ -781,8 +781,8 @@ class WebViewTestBase : public extensions::PlatformAppBrowserTest {
blink::WebInputEvent::NoModifiers,
blink::WebInputEvent::TimeStampForTesting);
mouse_event.button = blink::WebMouseEvent::Button::Right;
- mouse_event.x = 1;
- mouse_event.y = 1;
+ mouse_event.position.x = 1;
+ mouse_event.position.y = 1;
web_contents->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(
mouse_event);
mouse_event.setType(blink::WebInputEvent::MouseUp);
@@ -3459,8 +3459,8 @@ IN_PROC_BROWSER_TEST_P(WebViewAccessibilityTest, DISABLED_TouchAccessibility) {
blink::WebInputEvent::MouseMove,
blink::WebInputEvent::IsTouchAccessibility,
blink::WebInputEvent::TimeStampForTesting);
- accessibility_touch_event.x = 95;
- accessibility_touch_event.y = 55;
+ accessibility_touch_event.position.x = 95;
+ accessibility_touch_event.position.y = 55;
web_contents->GetRenderViewHost()->GetWidget()->ForwardMouseEvent(
accessibility_touch_event);

Powered by Google App Engine
This is Rietveld 408576698