Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2782843002: Complain about bad operator parameters. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -32 lines) Patch
M pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/operator.dart View 1 chunk +46 lines, -0 lines 4 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +22 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
3 years, 8 months ago (2017-03-29 09:47:24 UTC) #3
karlklose
LGTM https://codereview.chromium.org/2782843002/diff/20001/pkg/front_end/lib/src/fasta/operator.dart File pkg/front_end/lib/src/fasta/operator.dart (right): https://codereview.chromium.org/2782843002/diff/20001/pkg/front_end/lib/src/fasta/operator.dart#newcode105 pkg/front_end/lib/src/fasta/operator.dart:105: case Operator.add: Consider combining the cases for operators ...
3 years, 8 months ago (2017-03-29 10:12:02 UTC) #4
ahe
Thank you, Karl! https://codereview.chromium.org/2782843002/diff/20001/pkg/front_end/lib/src/fasta/operator.dart File pkg/front_end/lib/src/fasta/operator.dart (right): https://codereview.chromium.org/2782843002/diff/20001/pkg/front_end/lib/src/fasta/operator.dart#newcode105 pkg/front_end/lib/src/fasta/operator.dart:105: case Operator.add: On 2017/03/29 10:12:01, karlklose ...
3 years, 8 months ago (2017-03-29 10:55:00 UTC) #5
ahe
3 years, 8 months ago (2017-03-29 11:12:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
695ebae97a61346535f711249c9bda6d204a13a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698