Rewrite implementation of ClipboardRecentContent in Objective C.

components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/open_from_clipboard/clipboard_recent_content_ios.h"
 
 #import <CoreGraphics/CoreGraphics.h>
 #import <UIKit/UIKit.h>
 
 #include <memory>
@@ skipping 63 matching lines @@
                                 base::TimeDelta::FromSeconds(0));
   }
 
   void ResetClipboardRecentContent(const std::string& application_scheme,
                                    base::TimeDelta time_delta) {
     clipboard_content_.reset(new ClipboardRecentContentIOSWithFakeUptime(
         application_scheme, [NSUserDefaults standardUserDefaults]));
     clipboard_content_->SetUptime(time_delta);
   }
 
   void SetStoredPasteboardChangeDate(NSDate* changeDate) {

[jif, 2017/03/29 14:17:56]

original author messed up 🙄
s/changeData/change_date/

also, keep the call to |copy|.

[lody, 2017/03/30 13:36:34]

Done.

-    clipboard_content_->last_pasteboard_change_date_.reset([changeDate copy]);
+    clipboard_content_->SetLastPasteboardChangeDate(changeDate);
     clipboard_content_->SaveToUserDefaults();
   }
 
-  void SetStoredPasteboardChangeCount(NSInteger newChangeCount) {
-    clipboard_content_->last_pasteboard_change_count_ = newChangeCount;
-    clipboard_content_->SaveToUserDefaults();
-  }
-
  protected:
   std::unique_ptr<ClipboardRecentContentIOSWithFakeUptime> clipboard_content_;
 };
 
 TEST_F(ClipboardRecentContentIOSTest, SchemeFiltering) {
   GURL gurl;
 
   // Test unrecognized URL.
   SetPasteboardContent(kUnrecognizedURL);
   EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
@@ skipping 53 matching lines @@
   // Check that the pasteboard content is suppressed.
   EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
 
   // Create a new clipboard content to test persistence.
   ResetClipboardRecentContent(kAppSpecificScheme,
                               base::TimeDelta::FromDays(10));
 
   // Check that the pasteboard content is still suppressed.
   EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
 
   // Check that the even if the device is restarted, pasteboard content is

[jif, 2017/03/31 13:14:47]

thanks!

   // still suppressed.
   SimulateDeviceRestart();
   EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
 
   // Check that if the pasteboard changes, the new content is not
   // supressed anymore.
   SetPasteboardContent(kRecognizedURL2);
   EXPECT_TRUE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
 }
 
@@ skipping 12 matching lines @@
   SetPasteboardImage(TestUIImage());
 
   // Pasteboard should appear empty.
   EXPECT_FALSE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
 
   // Tests that if URL is added again, pasteboard provides it normally.
   SetPasteboardContent(kRecognizedURL);
   EXPECT_TRUE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
   EXPECT_STREQ(kRecognizedURL, gurl.spec().c_str());
 }