third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js ('K') | « third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CookieModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

index cc76e5beed0a61ff40b4aeda90e3c6ac4a469ee6..39ef897f403c517a9cfe6d1ee320b09ce56f9d83 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js

@@ -79,8 +79,7 @@ SDK.CSSStyleSheetHeader = class {

* @return {string}

_viaInspectorResourceURL() {

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(this.target());

- var frame = resourceTreeModel.frameForId(this.frameId);

+ var frame = this.target().model(SDK.ResourceTreeModel).frameForId(this.frameId);

caseq 2017/03/29 17:48:42 this._cssModel.target()... and nuke the remaining

dgozman 2017/04/01 00:22:44 Done.

console.assert(frame);

var parsedURL = new Common.ParsedURL(frame.url);

var fakeURL = 'inspector://' + parsedURL.host + parsedURL.folderPathComponents;