Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
index ae014b629ecfe074ea037e131b1ec97244be63eb..78afcfa78487be59fff657ba867fff1caed723b7 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
@@ -143,7 +143,7 @@ Accessibility.AccessibilityNode = class extends SDK.SDKObject {
if (!this.isDOMNode())
return;
this.deferredDOMNode().resolvePromise().then(node => {
- SDK.DOMModel.fromTarget(this.target()).nodeHighlightRequested(node.id);
+ this.target().model(SDK.DOMModel).nodeHighlightRequested(node.id);
caseq 2017/03/29 17:48:42 just do this.deferredDOMNode().highlight() instead
dgozman 2017/04/01 00:22:44 Done.
});
}
@@ -223,14 +223,6 @@ Accessibility.AccessibilityModel = class extends SDK.SDKModel {
this._backendDOMNodeIdToAXNode = new Map();
}
- /**
- * @param {!SDK.Target} target
- * @return {?Accessibility.AccessibilityModel}
- */
- static fromTarget(target) {
- return target.model(Accessibility.AccessibilityModel);
- }
-
clear() {
this._axIdToAXNode.clear();
}

Powered by Google App Engine
This is Rietveld 408576698