Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 setPreserveLog(preserveLog) { 385 setPreserveLog(preserveLog) {
386 this._preserveLog = preserveLog; 386 this._preserveLog = preserveLog;
387 } 387 }
388 388
389 /** 389 /**
390 * @override 390 * @override
391 * @param {!SDK.Target} target 391 * @param {!SDK.Target} target
392 */ 392 */
393 targetAdded(target) { 393 targetAdded(target) {
394 if (!target.parentTarget()) { 394 if (!target.parentTarget()) {
395 var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target); 395 var resourceTreeModel = target.model(SDK.ResourceTreeModel);
396 if (resourceTreeModel) { 396 if (resourceTreeModel) {
397 resourceTreeModel.addEventListener( 397 resourceTreeModel.addEventListener(
398 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavi gated, this); 398 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavi gated, this);
399 resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.Load, th is._loadEventFired, this); 399 resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.Load, th is._loadEventFired, this);
400 resourceTreeModel.addEventListener( 400 resourceTreeModel.addEventListener(
401 SDK.ResourceTreeModel.Events.DOMContentLoaded, this._domContentLoade dEventFired, this); 401 SDK.ResourceTreeModel.Events.DOMContentLoaded, this._domContentLoade dEventFired, this);
402 } 402 }
403 } 403 }
404 NetworkLog.networkLog.requestsForTarget(target).forEach(this._appendRequest. bind(this)); 404 NetworkLog.networkLog.requestsForTarget(target).forEach(this._appendRequest. bind(this));
405 } 405 }
406 406
407 /** 407 /**
408 * @override 408 * @override
409 * @param {!SDK.Target} target 409 * @param {!SDK.Target} target
410 */ 410 */
411 targetRemoved(target) { 411 targetRemoved(target) {
412 if (!target.parentTarget()) { 412 if (!target.parentTarget()) {
413 var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target); 413 var resourceTreeModel = target.model(SDK.ResourceTreeModel);
414 if (resourceTreeModel) { 414 if (resourceTreeModel) {
415 resourceTreeModel.removeEventListener( 415 resourceTreeModel.removeEventListener(
416 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavi gated, this); 416 SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavi gated, this);
417 resourceTreeModel.removeEventListener(SDK.ResourceTreeModel.Events.Load, this._loadEventFired, this); 417 resourceTreeModel.removeEventListener(SDK.ResourceTreeModel.Events.Load, this._loadEventFired, this);
418 resourceTreeModel.removeEventListener( 418 resourceTreeModel.removeEventListener(
419 SDK.ResourceTreeModel.Events.DOMContentLoaded, this._domContentLoade dEventFired, this); 419 SDK.ResourceTreeModel.Events.DOMContentLoaded, this._domContentLoade dEventFired, this);
420 } 420 }
421 } 421 }
422 } 422 }
423 423
(...skipping 1381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1805 */ 1805 */
1806 Network.NetworkGroupLookupInterface = function() {}; 1806 Network.NetworkGroupLookupInterface = function() {};
1807 1807
1808 Network.NetworkGroupLookupInterface.prototype = { 1808 Network.NetworkGroupLookupInterface.prototype = {
1809 /** 1809 /**
1810 * @param {!SDK.NetworkRequest} request 1810 * @param {!SDK.NetworkRequest} request
1811 * @return {?string} 1811 * @return {?string}
1812 */ 1812 */
1813 lookup(request) {} 1813 lookup(request) {}
1814 }; 1814 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698