Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
11 * 2. Redistributions in binary form must reproduce the above 11 * 2. Redistributions in binary form must reproduce the above
12 * copyright notice, this list of conditions and the following disclaimer 12 * copyright notice, this list of conditions and the following disclaimer
13 * in the documentation and/or other materials provided with the 13 * in the documentation and/or other materials provided with the
14 * distribution. 14 * distribution.
15 * 15 *
16 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. AND ITS CONTRIBUTORS 16 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. AND ITS CONTRIBUTORS
17 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. 19 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC.
20 * OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 * OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 /** 28 /**
29 * @implements {SDK.TargetManager.Observer} 29 * @implements {SDK.SDKModelObserver<!SDK.DOMModel>}
30 * @unrestricted 30 * @unrestricted
31 */ 31 */
32 Elements.InspectElementModeController = class { 32 Elements.InspectElementModeController = class {
33 constructor() { 33 constructor() {
34 this._toggleSearchAction = UI.actionRegistry.action('elements.toggle-element -search'); 34 this._toggleSearchAction = UI.actionRegistry.action('elements.toggle-element -search');
35 this._mode = Protocol.DOM.InspectMode.None; 35 this._mode = Protocol.DOM.InspectMode.None;
36 SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChan ged, this._suspendStateChanged, this); 36 SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChan ged, this._suspendStateChanged, this);
37 SDK.targetManager.observeTargets(this, SDK.Target.Capability.DOM); 37 SDK.targetManager.observeModels(SDK.DOMModel, this);
38 } 38 }
39 39
40 /** 40 /**
41 * @override 41 * @override
42 * @param {!SDK.Target} target 42 * @param {!SDK.DOMModel} domModel
43 */ 43 */
44 targetAdded(target) { 44 modelAdded(domModel) {
45 // When DevTools are opening in the inspect element mode, the first target c omes in 45 // When DevTools are opening in the inspect element mode, the first target c omes in
46 // much later than the InspectorFrontendAPI.enterInspectElementMode event. 46 // much later than the InspectorFrontendAPI.enterInspectElementMode event.
47 if (this._mode === Protocol.DOM.InspectMode.None) 47 if (this._mode === Protocol.DOM.InspectMode.None)
48 return; 48 return;
49 var domModel = SDK.DOMModel.fromTarget(target);
50 domModel.setInspectMode(this._mode); 49 domModel.setInspectMode(this._mode);
51 } 50 }
52 51
53 /** 52 /**
54 * @override 53 * @override
55 * @param {!SDK.Target} target 54 * @param {!SDK.DOMModel} domModel
56 */ 55 */
57 targetRemoved(target) { 56 modelRemoved(domModel) {
58 } 57 }
59 58
60 /** 59 /**
61 * @return {boolean} 60 * @return {boolean}
62 */ 61 */
63 isInInspectElementMode() { 62 isInInspectElementMode() {
64 return this._mode === Protocol.DOM.InspectMode.SearchForNode || 63 return this._mode === Protocol.DOM.InspectMode.SearchForNode ||
65 this._mode === Protocol.DOM.InspectMode.SearchForUAShadowDOM; 64 this._mode === Protocol.DOM.InspectMode.SearchForUAShadowDOM;
66 } 65 }
67 66
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 if (!Elements.inspectElementModeController) 118 if (!Elements.inspectElementModeController)
120 return false; 119 return false;
121 Elements.inspectElementModeController._toggleInspectMode(); 120 Elements.inspectElementModeController._toggleInspectMode();
122 return true; 121 return true;
123 } 122 }
124 }; 123 };
125 124
126 /** @type {?Elements.InspectElementModeController} */ 125 /** @type {?Elements.InspectElementModeController} */
127 Elements.inspectElementModeController = 126 Elements.inspectElementModeController =
128 Runtime.queryParam('isSharedWorker') ? null : new Elements.InspectElementMod eController(); 127 Runtime.queryParam('isSharedWorker') ? null : new Elements.InspectElementMod eController();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698