Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 704
705 var nodeIdsToResolve = new Set(); 705 var nodeIdsToResolve = new Set();
706 var timelineData = TimelineModel.TimelineData.forEvent(event); 706 var timelineData = TimelineModel.TimelineData.forEvent(event);
707 if (timelineData.backendNodeId) 707 if (timelineData.backendNodeId)
708 nodeIdsToResolve.add(timelineData.backendNodeId); 708 nodeIdsToResolve.add(timelineData.backendNodeId);
709 var invalidationTrackingEvents = TimelineModel.InvalidationTracker.invalidat ionEventsFor(event); 709 var invalidationTrackingEvents = TimelineModel.InvalidationTracker.invalidat ionEventsFor(event);
710 if (invalidationTrackingEvents) 710 if (invalidationTrackingEvents)
711 Timeline.TimelineUIUtils._collectInvalidationNodeIds(nodeIdsToResolve, inv alidationTrackingEvents); 711 Timeline.TimelineUIUtils._collectInvalidationNodeIds(nodeIdsToResolve, inv alidationTrackingEvents);
712 var relatedNodes = null; 712 var relatedNodes = null;
713 if (nodeIdsToResolve.size) { 713 if (nodeIdsToResolve.size) {
714 var domModel = SDK.DOMModel.fromTarget(target); 714 var domModel = target.model(SDK.DOMModel);
715 if (domModel) { 715 if (domModel) {
716 relatedNodes = await new Promise(fulfill => 716 relatedNodes = await new Promise(fulfill =>
717 domModel.pushNodesByBackendIdsToFrontend(nodeIdsToResolve, fulfill)) ; 717 domModel.pushNodesByBackendIdsToFrontend(nodeIdsToResolve, fulfill)) ;
718 } 718 }
719 } 719 }
720 720
721 return Timeline.TimelineUIUtils._buildTraceEventDetailsSynchronously( 721 return Timeline.TimelineUIUtils._buildTraceEventDetailsSynchronously(
722 event, model, linkifier, detailed, relatedNodes); 722 event, model, linkifier, detailed, relatedNodes);
723 } 723 }
724 724
(...skipping 1577 matching lines...) Expand 10 before | Expand all | Expand 10 after
2302 * @param {string=} warningType 2302 * @param {string=} warningType
2303 */ 2303 */
2304 appendWarningRow(event, warningType) { 2304 appendWarningRow(event, warningType) {
2305 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType); 2305 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
2306 if (warning) 2306 if (warning)
2307 this.appendElementRow(Common.UIString('Warning'), warning, true); 2307 this.appendElementRow(Common.UIString('Warning'), warning, true);
2308 } 2308 }
2309 }; 2309 };
2310 2310
2311 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache'); 2311 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698